Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 15, 2024 21:24
케밥케이스 사용
브라우저 기본 여백 삭제를 위해, 패딩과 마진 리셋 추가
* {
padding: 0;
margin: 0;
}
GANGYIKIM
approved these changes
Aug 19, 2024
Comment on lines
+19
to
+23
| <label for="email" class="login__label">이메일</label> | ||
| <div class="login__field--id"> | ||
| <input | ||
| type="text" | ||
| id="email" |
There was a problem hiding this comment.
P3:
label 과 input을 연결하신거 좋습니다 👍
Comment on lines
+59
to
+60
| <button type="submit" class="login__submit">로그인</button> | ||
| </form> |
There was a problem hiding this comment.
P3:
button 과 form 태그를 같이 쓰신거 좋습니다 👍
Comment on lines
+51
to
+53
| top: 50%; | ||
| right: 2.4rem; | ||
| transform: translateY(-50%); |
There was a problem hiding this comment.
P3:
중앙 정렬을 위해 이렇게 처리하신거 좋습니다 👍
아시겠지만 혹시나 해서 설명을 드리자면, 상대요소의 상단(top) 기준으로 50% 되는 곳에 위치시키게 되면
input height: 60px, icon height: 30px 일경우 60 * 0.5 = 30px 에 아이콘이 위치하게 됩니다.
시각적으로 중앙에 위치하기 위해서는 30px가 아닌 30 - (30 / 2) = 15px에 위치해야 합니다.
이를 고정값(15px)처럼 입력하게 되면 icon의 height가 변경되었을 시 같이 변경되야 하기 때문에 위와같이 작성합니다.
There was a problem hiding this comment.
P3:
login.css 와 중복되는 내용이 많을 것 같습니다.
중복을 줄일 방법을 고민해보시면 좋겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
1. 로그인 페이지, 회원가입 페이지 공통
2. 로그인 페이지
3. 회원가입 페이지
심화
주요 변경사항
스크린샷
1. 로그인 페이지
2. 회원가입 페이지
멘토에게